feat(general): add support for Python 3.11#2820
Conversation
boring-cyborg
bot
added
dependencies
pull-request-size
bot
added
the
size/S
heitorlessa
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2820 +/- ##
===========================================
+ Coverage 97.54% 97.57% +0.02%
===========================================
Files 162 162
Lines 7469 7469
Branches 540 1416 +876
===========================================
+ Hits 7286 7288 +2
+ Misses 134 133 -1
+ Partials 49 48 -1 ☔ View full report in Codecov by Sentry. |
|
TODO: remove snappy dependency and all references in examples and documentation /cc @leandrodamascena |
pull-request-size
bot
added
size/M
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
I added some important information I found on this PR before we merged.
| try: | ||
| cache.pop(key, None) | ||
| pytest.fail("GitHub #300: LRUDict pop bug has been fixed :)") | ||
| pytest.fail("GitHub #300: LRUDict pop bug has been fixed.") |
There was a problem hiding this comment.
NOTE: I removed some characters to allow for adding a comment.
First time I had contact with this and the test is falling. I understand why it's failing in Python 3.11, but I have no idea why we need it here. Do you have any information about this worth sharing @heitorlessa?
ERROR:
> pytest.fail("GitHub #300: LRUDict pop bug has been fixed.") E Failed: GitHub #300: LRUDict pop bug has been fixed.
There was a problem hiding this comment.
That was an old bug in the implementation of LRUDict from OrderedDict. Let's skip for 3.11+ until we have more quality time to dive into refactoring this.
There was a problem hiding this comment.
Added a skip for Python 3.11+.
boring-cyborg
bot
added
the
documentation
|
Can't update the examples because cfn-lint still doesn't offer support to Python 3.11 linting::cloudformation..................................................Failed
- hook id: cloudformation
- exit code: 2
E3030 You must specify a valid value for Runtime (python3.11). Valid values are ["dotnet6", "dotnetcore1.0", "dotnetcore2.0", "dotnetcore2.1", "dotnetcore3.1", "go1.x", "java11", "java17", "java8", "java8.al2", "nodejs", "nodejs10.x", "nodejs12.x", "nodejs14.x", "nodejs16.x", "nodejs18.x", "nodejs4.3", "nodejs4.3-edge", "nodejs6.10", "nodejs8.10", "provided", "provided.al2", "python2.7", "python3.10", "python3.6", "python3.7", "python3.8", "python3.9", "ruby2.5", "ruby2.7", "ruby3.2"]
examples/batch_processing/sam/dynamodb_batch_processing.yaml:17:3There is an issue to add support for this - aws-cloudformation/cfn-lint#2788 |
|
Hello @rubenfonseca! This is a HUGE amount of incredible WORK! We can merge this PR merge after @heitorlessa help us with a small problem in one of our tests. Congrats dude, this is an essential step for us. 🚀 ❤️ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you @rubenfonseca and @leandrodamascena - fantastic work ;) |
4 participants
Issue number: #2732
Summary
This PR adds support for Python 3.11.
Tasks to complete before merging this PR
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.